Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print URL to console #162

Merged
merged 2 commits into from
May 17, 2020
Merged

Print URL to console #162

merged 2 commits into from
May 17, 2020

Conversation

deroke
Copy link
Contributor

@deroke deroke commented May 13, 2020

@ondrejfuhrer
Copy link
Collaborator

Hello @DerZersaeger , thank you for the contribution! 👍
My question is, what would be the benefit of having it? Why would you like to see the URL in the output?

My concern is that with certain casks installed the output is already quite wide (yes, looking at you, Java!). So by adding more information the output will start wrapping into new lines making the output less readable.

How about adding that columns in verbose mode only? Would that make sense?

@yurikoles
Copy link
Contributor

When I saw PR title my first impression was that this related to parallel downloads ticket.

@DerZersaeger @ondrejfuhrer

Could you please also implement an option that will generate a download URLs with corresponding target files locations?

I'm also volunteering here, so advice will be very appreciated.

@yurikoles
Copy link
Contributor

Here is how it looks on my scaled terminal with large font.
proof

@ondrejfuhrer
Copy link
Collaborator

ondrejfuhrer commented May 13, 2020

So it is actually trimming the result so those URLs won't actually work, am I right here?

Could you please also implement an option that will generate a download URLs with corresponding target files locations?

Well, those URLs are even longer (imagine when the cask is downloaded from S3), what would be the use case here? @yurikoles

@yurikoles
Copy link
Contributor

Well, those URLs are even longer (imagine when the cask is downloaded from S3), what would be the use case here?

This output is not for humans, it's intended to be supplied to third party downloader.

@ondrejfuhrer
Copy link
Collaborator

@yurikoles So something like this?

> brew cu download-links
https://page1.com/application1.dmg
https://page2.com/application2.dmg
https://page3.com/application3.dmg

And then you would pipe that into another command to do your magic?

@yurikoles
Copy link
Contributor

@ondrejfuhrer
Yes, but I'm also thinking about file names, because brew generates path by adding some hash in front. The ~/Library/Caches/Homebrew/downloads/ may be assumed or gotten with brew --cache.

@yurikoles
Copy link
Contributor

@DerZersaeger sorry for hijacking thread :(

@ondrejfuhrer let's continue in #160

@deroke
Copy link
Contributor Author

deroke commented May 13, 2020

@DerZersaeger sorry for hijacking thread :(

@ondrejfuhrer let's continue in #160

No problem

@deroke
Copy link
Contributor Author

deroke commented May 13, 2020

Hello @DerZersaeger , thank you for the contribution! 👍
My question is, what would be the benefit of having it? Why would you like to see the URL in the output?

My concern is that with certain casks installed the output is already quite wide (yes, looking at you, Java!). So by adding more information the output will start wrapping into new lines making the output less readable.

How about adding that columns in verbose mode only? Would that make sense?

My intention is:
When I upgrade any cask(s) I want to see what have changed.

E.g. when I run brew cu -a -f and see that vscodium or rectangle is outdated, I have to find the corresponding repository and check the committed changes.

I'm just too lazy to search all the time for these repos, so I started with this PR.

PS: I'm from 🇩🇪 => 🇬🇧 should be improved

@deroke
Copy link
Contributor Author

deroke commented May 13, 2020

How about adding that columns in verbose mode only? Would that make sense?
@ondrejfuhrer

See: 91b2e6b

Grüße nach Berlin 🇩🇪 😄 👍

@ondrejfuhrer ondrejfuhrer merged commit 02a04c0 into buo:master May 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants