Saved state: correct instantiation of Parcelable internal objects from P... #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 9, 2013 18:33
…m Parcel The old implementation was crashing as the objects data was not retrieved correctly from the Parcel in the constructor.
"mAdapter" can be null when touching the view, if the adapter hasn't been set or it's been reset. I've also moved an access to a local variable after a null check in the (unused) getFirstChildAtColumn(int) method.
HeaderFooterListAdapter#getItemViewType(int) wasn't returning the correct view type for non-header/footer views. Furthermore, in StaggeredGridView#obtainView(int, View) the new generated StaggeredGridView.LayoutParams weren't set in the obtained view (hence the recycled views all had viewType=0, and were never re-used).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...arcel
The old implementation was crashing as the objects data was not
retrieved correctly from the Parcel in the constructor.