Allow for non-existent event types in Webhooks::Outgoing::Endpoint#event_types

[jagthedrummer]

Fixes: #654

The Set Up

Let's say you had created a Widget model, and had added widget.* events to config/models/webhooks/outgoing/event_types.yml:

scaffolding/absolutely_abstract/creative_concept:
  # This automatically generates `created`, `updated`, and `deleted` webhook events.
  - crud
scaffolding/completely_concrete/tangible_thing:
  - crud
invitation:
  - crud
membership:
  - crud
widget:
  - crud

And then you (or one of your users) sets up an Outgoing Webhook using one of the widget events. Effectively this:

  endpoint = Webhooks::Outgoing::Endpoint.create!(
    url: "https://example.com/webhook",
    name: "test",
    team: @team,
    event_type_ids: ["widget.created", "membership.created"]
  )

Then at a later time you decide that the Widget model was a bad idea, and so you remove it from event_types.yml.

Old Behavior

Previously, if you then called event_types on that endpoint we'd raise an ActiveHash::RecordNotFound error:

> endpoint.event_types
bullet_train-outgoing_webhooks (1.11.0)
  app/models/concerns/webhooks/outgoing/endpoint_support.rb:37:
  in `block in event_types':
  Couldn't find Webhooks::Outgoing::EventType with ID=widget.created
  (ActiveHash::RecordNotFound)
        from bullet_train-outgoing_webhooks (1.11.0) app/models/concerns/webhooks/outgoing/endpoint_support.rb:37:in `map'
        from bullet_train-outgoing_webhooks (1.11.0) app/models/concerns/webhooks/outgoing/endpoint_support.rb:37:in `event_types'

New Behavior

Now if you call event_types on that endpoint we'll return an ActiveRecord::Relation of Webhooks::Outgoing::EventType objects for the still-good event_type_ids for the endpoint. Since widget.created is no longer a valid type, it won't show up in the event_types array and we won't raise an error.

> endpoint.event_types
=> [
      #<Webhooks::Outgoing::EventType:0x000000014dddc068 
        @attributes={:id=>"membership.created"}>
   ]

Possible breaking change

Previously event_types would return an Array of Webhooks::Outgoing::EventType objects.

Now it returns an ActiveRecord::Relation of Webhooks::Outgoing::EventType objects.

[RichStone]

Nice one adding tests here, I now see the most probable reason for the raise here 👀

[RichStone]

Yeah, maybe this was one of the reasons why the .find() was there, namely to raise on creation, since there is no other validation in place for that. It did make sense that we raised before here.