Update stripe connect and omniauth gems #1012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches out a dependency for Stripe Connect.
We used to use
omniauth-stripe-connectbut it hasn't been updated in quite sometime and it's pegged to versions ofominauthon the1.xline. Unfortunately the1.xline of ominauth has some security vulnerabilities. In order to updateomniauthto the2.xline we're moving toomniauth-stripe-connect-v2which is basically the same asomniauth-stripe-connectbut with a.gemspecthat allowsomniauthversions~> 2.0.This also bumps the version of
omniauth-rails_csrf_protectionto~> 1.0so that it works with the new stripe connect gem.The docs for all of the new versions are the same as the docs for the old versions, so there shouldn't be any application changes required. I've tested these in my local starter repo and I can connect to Stripe accounts both for user sign in and for purposes of creating a Stripe Installation for marketplace scenarios.
Fixes #1007