Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bullet_train-integrations-stripe's outdated omniauth dependency #1007

Closed
zackgilbert opened this issue Jan 24, 2025 · 0 comments · Fixed by #1012
Closed

Update bullet_train-integrations-stripe's outdated omniauth dependency #1007

zackgilbert opened this issue Jan 24, 2025 · 0 comments · Fixed by #1012

Comments

@zackgilbert
Copy link

zackgilbert commented Jan 24, 2025

Is there any plan to update the bullet_train-integrations-stripe gem's dependencies, specifically the use of omniauth (which is currently stuck at 1.9.2)?

Would love to get this updates to help address a security concern that has been present for more than 2 years now:

The latest possible version that can be installed is 1.9.2 because of the following conflicting dependency:

bullet_train-integrations-stripe (1.12.3) requires omniauth (~> 1.3) via omniauth-stripe-connect (2.10.1)
The earliest fixed version is 2.0.0.

The request phase of the OmniAuth Ruby gem (1.9.2 and earlier) is vulnerable to Cross-Site Request Forgery when used as part of the Ruby on Rails framework, allowing accounts to be connected without user intent, user interaction, or feedback to the user. This permits a secondary account to be able to sign into the web application as the primary account.

As of v2 OmniAuth no longer has the vulnerable configuration by default, but it is still possible to configure OmniAuth in such a way that the web application becomes vulnerable to Cross-Site Request Forgery. There is a recommended remediation described here.

It doesn't look like the underlying gem (omniauth-stripe-connect) has been updated in a while and might not be maintained anymore, but it does look like there is a new gem (omniauth-stripe-connect-v2) that wouldn't be subject to the known issues.

Not sure how easy it would be to update things to use this, but wanted to make sure that it was on people's radar. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant