Repository navigation
Conversation
Port /parameters from upstream Bugzilla (bug 443210). Logged-out users get maintainer and requirelogin, logged-in users get the params already visible in the web UI, and tweakparams members get every param. In Harmony, urlbase and attachment_base moved from data/params to localconfig, so they are served from Bugzilla->localconfig. cookiepath and maxlocalattachment no longer exist and are omitted. last_audit_time from the same upstream patch is not included.
mrenvoize
requested changes
Oct 31, 2026
mrenvoize
left a comment
Contributor
There was a problem hiding this comment.
Requesting changes, mostly for tests and a policy decision. The access model reads as sound (anonymous gets maintainer/requirelogin; logged-in users a whitelist; tweakparams all keys).
- Secrets via the API: please decide whether
tweakparamsusers should receive secret params (smtp_password,aws_secret_access_key,duo_skey,duo_akey,duo_ikey). The web UI already shows them, but the API is easier to scrape; I'd suggest masking them. - Tests: there are none, and the webservice tests do not run in CI (the job is commented out in
.github/workflows/ci.yml:28-37). Please add tests for the anonymous, logged-in and admin views and run them locally. - The docs say "Restored in 6.0" but
BUGZILLA_VERSIONis 5.9.1+; please correct. perltidy flags line 185.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1582393
The /parameters endpoint returned "No such method" because Bugzilla.parameters was never ported to Harmony. This ports it from upstream Bugzilla (bug 443210), keeping the same access tiers:
Harmony-specific changes:
Not included: last_audit_time from the same upstream patch. It is a separate method outside this bug, and I can port it separately if wanted.
Tested locally in Docker:
The plain logged-in tier was not exercised live because my local DB has no non-admin test user. It runs the same code path with a different parameter list.