Skip to content

Conversation

@adarshaks91
Copy link
Contributor

Description

Data files were not being included in the gemspec regex and hence were not being included in the package during the build

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the gemspec to include all data files in the package by removing the file extension filter, and bumps the version to reflect this packaging fix.

  • Updated gemspec to include all files under lib/ directory instead of only .rb and .json files
  • Incremented version from 0.7.0 to 0.7.1

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
lib/bmt/version.rb Version bump to 0.7.1
bmt.gemspec Modified file inclusion pattern to capture all data files

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

spec.homepage = 'https://github.com/bugcrowd/bmt-ruby'
spec.license = 'MIT'
spec.files = Dir['lib/**/*.{rb,json}']
spec.files = Dir['lib/**/*']
Copy link

Copilot AI Aug 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The wildcard pattern lib/**/* may include unintended files like backup files, temporary files, or development artifacts. Consider using a more specific pattern like Dir['lib/**/*.{rb,json,yml,yaml,xml,txt}'] to explicitly include only the data file types you need.

Suggested change
spec.files = Dir['lib/**/*']
spec.files = Dir['lib/**/*.{rb,json,yml,yaml,xml,txt}']

Copilot uses AI. Check for mistakes.
@adarshaks91 adarshaks91 removed the request for review from fedetaglia August 20, 2025 14:46
@adarshaks91 adarshaks91 marked this pull request as draft August 20, 2025 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants