Print unexpected success cases in the conformance runner (#335)

timostamm · web-flow · commit 0e59ac397101 · 2025-03-11T20:40:09.000+01:00
diff --git a/tools/protovalidate-conformance/internal/results/set.go b/tools/protovalidate-conformance/internal/results/set.go
@@ -70,7 +70,9 @@ func (suite *SuiteResults) AddCase(res *harness.CaseResult, verbose bool) {
 	default:
 		suite.Failures++
 	}
-	if verbose || (!res.GetSuccess() && !res.GetExpectedFailure()) {
+	unexpectedFailure := !res.GetSuccess() && !res.GetExpectedFailure()
+	unexpectedSuccess := res.GetSuccess() && res.GetExpectedFailure()
+	if verbose || unexpectedFailure || unexpectedSuccess {
 		suite.Cases = append(suite.Cases, res)
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -70,7 +70,9 @@ func (suite SuiteResults) AddCase(res harness.CaseResult, verbose bool) {`
`70`	`70`	`default:`
`71`	`71`	`suite.Failures++`
`72`	`72`	`}`
`73`		`- if verbose \|\| (!res.GetSuccess() && !res.GetExpectedFailure()) {`
	`73`	`+ unexpectedFailure := !res.GetSuccess() && !res.GetExpectedFailure()`
	`74`	`+ unexpectedSuccess := res.GetSuccess() && res.GetExpectedFailure()`
	`75`	`+ if verbose \|\| unexpectedFailure \|\| unexpectedSuccess {`
`74`	`76`	`suite.Cases = append(suite.Cases, res)`
`75`	`77`	`}`
`76`	`78`	`}`