Skip to content

Commit 19dee1a

Browse files
authored
Delete the --strict flag of the conformance runner (#334)
1 parent 51b65b6 commit 19dee1a

File tree

6 files changed

+80
-97
lines changed

6 files changed

+80
-97
lines changed

docs/conformance.md

-1
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ You can customize the behavior of the tests using the following flags:
2626
| `--case <regex>` | Filter cases using the provided regular expression. | None |
2727
| `--timeout <duration>` | Set a per-suite timeout. | 5 seconds |
2828
| `--verbose`, `-v` | Enable verbose output. | `false` |
29-
| `--strict` | Enable strict mode. Require that the violation type is an exact match. | `false` |
3029
| `--strict_message` | Require that violation messages match the expected message exactly. | `false` |
3130
| `--strict_error` | Require that compile-time errors are distinguished from runtime errors. | `false` |
3231
| `--proto` | Return results as binary serialized message `buf.validate.conformance.harness.ResultSet` to stdout. | `false` |

proto/protovalidate-testing/buf/validate/conformance/harness/results.proto

+2-2
Original file line numberDiff line numberDiff line change
@@ -29,12 +29,12 @@ message ResultOptions {
2929
string case_filter = 2;
3030
// If the test runner should print verbose output.
3131
bool verbose = 3;
32-
// If the violation type must be an exact match.
33-
bool strict = 4;
3432
// If the violation message must be an exact match.
3533
bool strict_message = 5;
3634
// If the distinction between runtime and compile time errors must be exact.
3735
bool strict_error = 6;
36+
reserved 4;
37+
reserved "strict";
3838
}
3939

4040
// A result is the result of a test run.

tools/internal/gen/buf/validate/conformance/harness/results.pb.go

+76-86
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

tools/protovalidate-conformance/config.go

-2
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ type config struct {
3434
caseFilter *regexp.Regexp
3535
suiteTimeout time.Duration
3636
verbose bool
37-
strict bool
3837
strictMessage bool
3938
strictError bool
4039
proto bool
@@ -61,7 +60,6 @@ func parseFlags() (*config, error) {
6160
flag.StringVar(&cfg.caseFilterPattern, "case", cfg.caseFilterPattern, "regex to filter cases")
6261
flag.DurationVar(&cfg.suiteTimeout, "timeout", cfg.suiteTimeout, "per-suite timeout")
6362
flag.BoolVarP(&cfg.verbose, "verbose", "v", cfg.verbose, "verbose output")
64-
flag.BoolVar(&cfg.strict, "strict", cfg.strict, "require that the violation type is an exact match")
6563
flag.BoolVar(&cfg.strictMessage, "strict_message", cfg.strictMessage, "require that violation messages match the expected message exactly")
6664
flag.BoolVar(&cfg.strictError, "strict_error", cfg.strictError, "require that compile-time errors are distinguished from runtime errors")
6765
flag.BoolVar(&cfg.proto, "proto", cfg.proto, "return results as binary serialized proto to stdout")

0 commit comments

Comments
 (0)