-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] Rotate4D #368
[feat] Rotate4D #368
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Giving quick feedback. Please add unit test for your operation and vectorization pass.
examples/DIPDialect/rotation4D.cpp
Outdated
testImplementation(argc, argv); | ||
|
||
return 0; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add an empty line here.
The following function will cause linker failure if the DIP related header files are included multiple times. |
* [feat] accelerate rotate2d, add rotate4d affine part. * [feat] finish rotate_4d(nhwc and nchw format) * [modify] add test, fix code format. * clean up code format using pre-commit * [fix] force inline in DIP header file to avoid link failure * [fix] format code with pre-commit
Finish Rotate4D Operation in DIP dialect.
run commands (in buddy-mlir dir)
$ cd build
$ cmake -G Ninja .. -DBUDDY_EXAMPLES=ON -DBUDDY_ENABLE_OPENCV=ON -DBUDDY_MLIR_ENABLE_DIP_LIB=ON
$ ninja rotation4D
$ cd bin
$ ./rotation4D ../../examples/images/YuTu.png result-dip-rotate.png