-
Notifications
You must be signed in to change notification settings - Fork 2
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
1 parent
98cee62
commit 914b0a6
Showing
1 changed file
with
1 addition
and
55 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,58 +1,4 @@ | ||
## Submission notes bsvarSIGNs v1.0 | ||
|
||
## R CMD check results | ||
|
||
There were no ERRORs, WARNINGs, or NOTEs. | ||
|
||
## GitHub R-CMD-check using `usethis::use_github_action_check_standard()` | ||
|
||
Passing on all platforms! | ||
|
||
## Check at using `devtools::check(manual = TRUE, remote = TRUE, incoming = TRUE)` | ||
|
||
This shows: | ||
> Maintainer: ‘Xiaolei Wang <[email protected]>’ | ||
> Found the following (possibly) invalid URLs: | ||
> URL: https://www.linkedin.com/in/tomaszwwozniak | ||
> From: README.md | ||
> Status: 999 | ||
> URL: https://www.linkedin.com/in/xiaolei-adam-wang/ | ||
> From: README.md | ||
> Status: 999 | ||
This is not a problem with the link, but how LinkedIn responds to automatic checks as documented e.g. [HERE](https://stackoverflow.com/questions/27231113/999-error-code-on-head-request-to-linkedin) and [HERE](https://http.dev/999) | ||
|
||
It also shows: | ||
> Package in Depends/Imports which should probably only be in LinkingTo: ‘RcppArmadillo’ | ||
This is not a problem as `RcppArmadillo` is used in the package and is not a problem to be in `Depends` or `Imports`. We tested various scenarios of includeing `RcppArmadillo` in dependencies, and only the current setup compiles and installs the package correctly. It shows this note nevertheless. | ||
|
||
## Checks using `devtools::check_win_devel()` | ||
|
||
This show as well: | ||
> Possibly misspelled words in DESCRIPTION: | ||
> Autoregression (9:215) | ||
> Autoregressions (3:49, 9:100) | ||
> Giannone (9:324) | ||
> Lenza (9:334) | ||
> Primiceri (9:341) | ||
> Rubio (9:458, 9:633, 9:848) | ||
> Waggoner (9:474, 9:651) | ||
> Zha (9:485) | ||
> az (9:841) | ||
> bsvarSIGNs (9:1347) | ||
> decompositions (9:1114) | ||
> niak (9:1462) | ||
> rez (9:469, 9:644, 9:859) | ||
> toolset (9:1544) | ||
All are correct and used intentionally. Thanks! | ||
|
||
## Done some more tests from `usethis::use_release_issue()` | ||
|
||
All good here! | ||
|
||
## Submission notes bsvarSIGNs v1.0.1 | ||
# Submission notes bsvarSIGNs v1.0.1 | ||
|
||
## Checks using `rhub::rhub_check()` | ||
|
||
|