Fix randomly selected rows #164 #231
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes bryanmylee#164 Issue occurs when children string property is an empty array
bryanmylee
reviewed
Oct 28, 2024
| @@ -35,8 +35,17 @@ export const addSubRows = | |||
| NewTablePropSet<never> | |||
| > => | |||
| () => { | |||
| const getChildren: ValidChildrenFn<Item> = | |||
| children instanceof Function ? children : (item) => item[children] as unknown as Item[]; | |||
| let getChildren: ValidChildrenFn<Item>; | |||
There was a problem hiding this comment.
Given that ValidChildrenFn has an optional return value, the original intention is that getChildren should return undefined if invalid.
Furtherfore, there is a semantic difference between returning [] and undefined, so the added unknownVal.length > 0 check is an incorrect addition.
|
It seems like the original issue stems from IDs being incorrectly selected when there are no valid children? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #164. Issue occurs when children string property is an empty array.
Updated
createSamplesto randomly exclude children.TODO