Update codecept.conf.js #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With default screen size the "Sign in" might not be displayed on Github.com
sourav-kundu
reviewed
Sep 2, 2021
| @@ -20,6 +20,7 @@ exports.config = { | |||
| output: './output', | |||
| helpers: { | |||
| Puppeteer: { | |||
| windowSize: '1920x1080', | |||
There was a problem hiding this comment.
If the screen resolution is smaller than part of the window will go out of the screen.
Lets try the viewport: null option which maximises the browser window according to the screen resolution
There was a problem hiding this comment.
I've added the default viewport setting but I cannot really tell if it make any difference on BS side... Any idea how to test it?
Adding `defaultViewport: null` as you suggested. Following recommendation from that issue: codeceptjs/CodeceptJS#1209
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With default screen size the "Sign in" might not be displayed on Github.com