Skip to content

Ensure calling .stop does not error if callback is not passed in #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 15, 2017
Merged

Ensure calling .stop does not error if callback is not passed in #34

merged 2 commits into from
Jun 15, 2017

Conversation

ldabiralai
Copy link
Contributor

Before this PR calling .stop() without a callback would error

@jamesaspence
Copy link
Contributor

I created a very similar PR (#35) that adds an optional callback to start as well as stop :)

@jamesaspence
Copy link
Contributor

Perhaps we can merge these two PRs into one?

@vedharish vedharish merged commit 2b4e615 into browserstack:master Jun 15, 2017
@vedharish
Copy link
Contributor

Please see #35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ldabiralai @jamesaspence @vedharish