Skip to content

Fixing ignore option causing failure #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
grunka wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fixing ignore option causing failure #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
97bf33d
Ignore is a valid option for this transform but not for terser
grunka Nov 23, 2022
fd01075
xtend not used
grunka Nov 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,11 @@ const minimatch = require('minimatch').Minimatch
const convert = require('convert-source-map')
const through = require('through2')
const path = require('path')
const xtend = require('xtend')

module.exports = uglifyify

function uglifyify (file, opts) {
opts = xtend(opts || {})
opts = Object.assign({}, opts || {});

let debug = opts._flags && opts._flags.debug
// lazy require `terser` so uglifyify can be loaded on very old node.js versions
Expand All @@ -16,6 +15,7 @@ function uglifyify (file, opts) {
if (ignore(file, opts.ignore)) {
return through()
}
delete opts.ignore;

let buffer = ''
const exts = []
Expand Down Expand Up @@ -45,7 +45,7 @@ function uglifyify (file, opts) {
}, capture(function ready (callback) {
const stream = this
debug = opts.sourceMap !== false && debug
opts = xtend({
opts = Object.assign({
compress: true,
mangle: true,
sourceMap: {
Expand All @@ -57,7 +57,7 @@ function uglifyify (file, opts) {
mapArgv(opts)

if (typeof opts.compress === 'object') {
opts.compress = xtend(opts.compress || {})
opts.compress = Object.assign({}, opts.compress || {})
delete opts.compress._
}

Expand Down
3 changes: 1 addition & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,7 @@
"convert-source-map": "^1.9.0",
"minimatch": "^3.0.2",
"terser": "^5.15.1",
"through2": "^4.0.2",
"xtend": "^4.0.1"
"through2": "^4.0.2"
},
"devDependencies": {
"bl": "^5.0.0",
Expand Down