support multi-byte wide typed arrays #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
force-pushed
the
ChALkeR-patch-1
branch
from
1deb57b to
2c19df0
Compare
ljharb
force-pushed
the
ChALkeR-patch-1
branch
2 times, most recently
from
98d7ab4 to
c8f6626
Compare
ljharb
force-pushed
the
ChALkeR-patch-1
branch
from
c8f6626 to
0a7c9a0
Compare
ljharb
force-pushed
the
ChALkeR-patch-1
branch
from
0a7c9a0 to
f76e123
Compare
|
Looks like node < 8 doesn't support passing a typed array directly into |
|
@ljharb yes, but newer versions do + this impl works regardless when proper |
|
ah ok cool. then we just need an easy way to feature-detect whether update takes a typed array, for the tests :-) |
ChALkeR
force-pushed
the
ChALkeR-patch-1
branch
5 times, most recently
from
c0f425f to
5c0a9d9
Compare
ljharb
reviewed
Jun 30, 2025
ljharb
approved these changes
Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as: browserify/hash-base#19, browserify/cipher-base#23, but retains support for Array and Array-like objects, since this module isn't closely mimicking the Node.js API
For array-likes, coherence rechecks are added to ensure invalid results are not returned
On everything Node.js createHash works, this now should be compatible + additionally keeps array-like support