Skip to content

fix: allow overriding entry point in browser field #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+21 −1
Open

fix: allow overriding entry point in browser field #101

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion index.js
View file
Original file line number Diff line number Diff line change
@@ -169,7 +169,9 @@ function build_resolve_opts(opts, base) {
}

var replace_main = replacements[info.main || './index.js'] ||
replacements['./' + info.main || './index.js'];
replacements['./' + info.main || './index.js'] ||
replacements['.'] ||
replacements['./'];

info.main = replace_main || info.main;
return info;
Empty file added test/fixtures/node_modules/entry-point-overridden-in-browser-field/foo/bar.js
View file
Empty file.
5 changes: 5 additions & 0 deletions test/fixtures/node_modules/entry-point-overridden-in-browser-field/package.json
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions test/modules-sync.js
View file
Original file line number Diff line number Diff line change
@@ -158,3 +158,8 @@ test('alt-browser field', function() {
var path = resolve.sync('url', parent);
assert.equal(path, require.resolve('./fixtures/node_modules/alt-browser-field/url-chromeapp'));
});

test('allow overriding entry point in browser field', function() {
var path = resolve.sync('entry-point-overridden-in-browser-field', { paths: [ fixtures_dir ], package: { main: 'fixtures' } });
assert.equal(path, require.resolve('./fixtures/node_modules/entry-point-overridden-in-browser-field/foo/bar.js'));
});
8 changes: 8 additions & 0 deletions test/modules.js
View file
Original file line number Diff line number Diff line change
@@ -338,3 +338,11 @@ test('respect symlinks', function (done) {
done();
});
});

test('allow overriding entry point in browser field', function (done) {
resolve('entry-point-overridden-in-browser-field', { paths: [ fixtures_dir ] }, function(err, path, pkg) {
assert.ifError(err);
assert.equal(path, require.resolve('./fixtures/node_modules/entry-point-overridden-in-browser-field/foo/bar.js'));
done();
});
});