test: turn existing templates in js files#87
Conversation
…ed and rewritten with new build
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 5b91a7e. Configure here.
|
|
||
| const includeTemplates = new Set(parseListFlag(argv, "--include-template")); | ||
| const includePaths = parseListFlag(argv, "--include-path"); | ||
| const excludePathOnly = parseListFlag(argv, "--exclude-path"); |
There was a problem hiding this comment.
CLI flags parsed redundantly in two places
Low Severity
parseListFlag for --include-template, --include-path, and --exclude-path is called both inside createFileFilter and again at the top of buildJavaScriptTemplates. The results serve the same logical purpose (determining which templates/paths are active), creating a maintenance risk: any change to flag semantics or names needs to stay in sync across both call sites.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 5b91a7e. Configure here.
1 participant
Note
Medium Risk
Adds new GitHub Actions workflows that fetch a public templates list, generate
javascript/, and auto-commit pushes to protected branches; failures or API changes could block merges or produce unexpected generated output.Overview
Introduces a playground-only TypeScript→JavaScript generation pipeline: new workflows for
productionandtest-productionrunci:playgroundto buildjavascript/from only templates marked playground-runnable by the public templates API, validate the sources, and (on branch pushes) commit the regeneratedjavascript/back to the branch.Adds new build/validation tooling (
scripts/build-javascript.mjs,scripts/playground-ci.mjs,scripts/validate-playground-templates.mjs, and helpers) plus new package scripts and atypescriptdevDependency; updates the README to clarify thattypescript/is the source of truth and full-tree JS generation is now local-only. Also addsCODEOWNERSentries requiring Dashboard review for the generated JS and the new playground CI scripts/workflow.Reviewed by Cursor Bugbot for commit 5b91a7e. Bugbot is set up for automated code reviews on this repo. Configure here.