Skip to content

Adding zod validation #690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

CtrlAltGiri
Copy link

@CtrlAltGiri CtrlAltGiri commented Apr 20, 2025

why

Adding zod validation errors in the error response to ensure better debugging for developers.

Resolving issue: #689

what changed

  1. Adding a new ZodValidationError.
  2. Stringifying the JSON in the ValidationError.

test plan

Copy link

changeset-bot bot commented Apr 20, 2025

⚠️ No Changeset found

Latest commit: 36b77de

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Added Zod schema validation across LLM clients to provide consistent, type-safe response handling and improved error reporting.

  • Added new types/zod.ts with validateZodSchemaWithResult utility for standardized schema validation
  • Introduced CreateChatCompletionResponseValidationError for structured validation failures
  • Implemented consistent validation in both GoogleClient and OpenAIClient with detailed error messages
  • Added retry mechanism when validation fails in both LLM clients
  • Aligned validation approach between providers while maintaining provider-specific response handling

💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!

4 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant