-
Notifications
You must be signed in to change notification settings - Fork 643
OpenAICUAClient.ts and AnthropicCUAClient.ts pass the whole clientOptions
to the LLM constructor
#644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 4fdfea8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
The changes update the OpenAICUAClient to read and apply the baseURL from clientOptions, aligning its behavior with AnthropicCUAClient.
- In
/lib/agent/OpenAICUAClient.ts
, baseURL is extracted from clientOptions if provided. - The baseURL is injected into the clientOptions before initializing the OpenAI client.
- This adjustment ensures consistency with AnthropicCUAClient for comprehensive client configuration.
💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
Thanks so much for opening this PR! Ideally this would take the entire |
27f6df7
to
4fdfea8
Compare
baseUrl
from clientOptions
clientOptions
to the LLM constructor
Thanks @kamath! As I mentioned in the issue, ideally, we would be able to pass the whole But for now, to unblock our pilot implementation, just that |
}; | ||
|
||
if (this.baseURL) { | ||
this.clientOptions.baseUrl = this.baseURL; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This probably didn't work as it was setting baseUrl
instead of baseURL
why
#643
what changed
OpenAICUAClient now respects
baseURL
passed in the options