You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In packages/sdk-go/browserbase_session.go, if extension.validate() fails after a successful upload, invoke deleteExtensionBestEffort using context.WithoutCancel(ctx) when a non-empty extension ID is present.
Prevents accumulating orphaned extensions on the Browserbase account when metadata validation fails on otherwise successful uploads.
Summary by cubic
Fixes orphaned Browserbase extensions accumulating when extension metadata validation fails after a successful upload.
The SDK now deletes the uploaded extension best-effort on validation failure when a non-empty extension ID is present.
Cleanup uses context.WithoutCancel(ctx), so deletion still runs even if the original request context is canceled.
The original validation error is still returned, joined with any cleanup error via errors.Join.
Written for commit 1d9f004. Summary will update on new commits.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
This PR is from an external contributor and must be approved by a stagehand team member with write access before CI can run.
Approving the latest commit mirrors it into an internal PR owned by the approver.
If new commits are pushed later, the internal PR stays open but is marked stale until someone approves the latest external commit and refreshes it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
packages/sdk-go/browserbase_session.go, ifextension.validate()fails after a successful upload, invokedeleteExtensionBestEffortusingcontext.WithoutCancel(ctx)when a non-empty extension ID is present.Summary by cubic
Fixes orphaned Browserbase extensions accumulating when extension metadata validation fails after a successful upload.
context.WithoutCancel(ctx), so deletion still runs even if the original request context is canceled.errors.Join.Written for commit 1d9f004. Summary will update on new commits.