Skip to content

Conversation

Samat-Imamov
Copy link

@Samat-Imamov Samat-Imamov commented Sep 9, 2025

Issue: #1030

why

Allowing authentication using provided client certificates during local runs.

what changed

Additional configuration value 'clientCertificates' that's being passed during Playwright context creation.

test plan

This is additional support for already existing Playwright feature so Playwright team's internal test for this feature should be enough. But to test locally, provide client certificate config according to this API - https://playwright.dev/docs/api/class-browser#browser-new-context-option-client-certificates - and authenticate to whichever service that certificate belongs to.

Copy link

changeset-bot bot commented Sep 9, 2025

⚠️ No Changeset found

Latest commit: 821688e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Summary

This PR adds client certificate support to enable authentication using provided client certificates during local browser runs. The implementation extends the existing LocalBrowserLaunchOptions interface with a clientCertificates property that gets passed through to Playwright's context creation, leveraging Playwright's built-in client certificate authentication feature.

Confidence score: 4/5

  • This PR is safe to merge with minimal risk as it adds optional client certificate support
  • Score reflects straightforward implementation that extends existing configuration pattern and leverages proven Playwright functionality without breaking changes
  • No files require special attention - this is a simple additive feature

2 files reviewed, no comments

Edit Code Review Bot Settings | Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant