Skip to content

Conversation

@monadoid
Copy link

@monadoid monadoid commented Jan 8, 2026

why

Addressing some of the notion comments for stainless python.

what changed

  • Updated examples + readme to show async python examples instead
  • Added a helper for calling session methods without passing session ID each time.
  • Docs only show using uv

test plan


Summary by cubic

Adds sessions.create() that returns a Session/AsyncSession bound to a session_id, so you can call session methods without passing id on every request. Moves examples and docs to AsyncStagehand and fixes session_id state issues.

  • New Features

    • client.sessions.create(...) wraps start and returns a bound Session/AsyncSession.
    • Session helpers expose navigate, observe, act, extract, execute, end (sync and async).
    • Stagehand.sessions now uses SessionsResourceWithHelpers to include create().
    • Updated README and examples to AsyncStagehand and the new create() pattern.
    • Added tests verifying create returns a bound session and methods work.
  • Migration

    • Replace client.sessions.start(...) with client.sessions.create(...).
    • Use the returned session: session.navigate(...), session.act(...), session.extract(...), session.execute(...), session.end().
    • Stop passing id= on each call.

Written for commit ba50c85. Summary will update on new commits.

@monadoid monadoid marked this pull request as ready for review January 9, 2026 22:37
Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 9 files

@monadoid monadoid changed the title Added session create helper Addressing stainless notion doc comments Jan 9, 2026
Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 issues found across 2 files (changes from recent commits).

Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="README.md">

<violation number="1" location="README.md:232">
P1: User-facing installation command requires uv, which most users won't have installed. This should use standard pip for general usage instructions.</violation>
</file>

<file name="CONTRIBUTING.md">

<violation number="1" location="CONTRIBUTING.md:94">
P2: Use `uv pip install` instead of `uv run pip install`. The correct uv syntax for pip operations is `uv pip <command>`, not `uv run pip <command>`.</violation>

<violation number="2" location="CONTRIBUTING.md:112">
P2: Use `uv pip install` instead of `uv run pip install`. The correct uv syntax for pip operations is `uv pip <command>`, not `uv run pip <command>`.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

@monadoid monadoid changed the title Addressing stainless notion doc comments Addressing (some) stainless notion doc comments Jan 9, 2026
monadoid added a commit to browserbase/stagehand that referenced this pull request Jan 10, 2026
# why
Once [this PR](browserbase/stagehand-python#264)
is merged into core, we no longer need to send `x-language` and
`x-sdk-version` headers in our generated SDKs, since they send the
`x-stainless` equivalents automatically.
# what changed
Thus, this PR removes these from the openapi spec, so that the generated
clients will stop having these fields.
# test plan
Will ensure that new generated sdks work successfully.

<!-- This is an auto-generated description by cubic. -->
---
## Summary by cubic
Removed x-language and x-sdk-version headers from the OpenAPI spec and
server types, since generated SDKs now send x-stainless headers
automatically. This simplifies SDK generation and removes redundant
headers.

- **Migration**
- Regenerate SDKs after the core change that adds x-stainless headers is
merged.
- Stop sending x-language and x-sdk-version in clients; rely on
x-stainless headers.

<sup>Written for commit df65fe9.
Summary will update on new commits.</sup>

<!-- End of auto-generated description by cubic. -->
@monadoid monadoid merged commit 8c3a33b into stainless Jan 10, 2026
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants