Skip to content

Conversation

@sdebruyn
Copy link

@sdebruyn sdebruyn commented Sep 23, 2025

Overview

It replaces all the SQL style comments (/* ... */) with Jinja style comments ({# ... #}).

Update type - breaking / non-breaking

  • [] Minor bug fix
  • Documentation improvements
  • Quality of Life improvements
  • New features (non-breaking change)
  • New features (breaking change)
  • Other (non-breaking change)
  • Other (breaking change)
  • Release preparation

What does this solve?

Nothing, just a quality of life improvement to not clutter logs.

Outstanding questions

/

What databases have you tested with?

  • Snowflake
  • Google BigQuery
  • Databricks
  • Spark
  • N/A

This comment is not rendered by Jinja, so it never gets sent to a database.

Copilot AI review requested due to automatic review settings September 23, 2025 14:44
@sdebruyn sdebruyn had a problem deploying to Approve Integration Tests September 23, 2025 14:44 — with GitHub Actions Failure
@sdebruyn sdebruyn had a problem deploying to Approve Integration Tests September 23, 2025 14:44 — with GitHub Actions Failure
@sdebruyn sdebruyn had a problem deploying to Approve Integration Tests September 23, 2025 14:44 — with GitHub Actions Failure
@sdebruyn sdebruyn had a problem deploying to Approve Integration Tests September 23, 2025 14:44 — with GitHub Actions Failure
@sdebruyn sdebruyn had a problem deploying to Approve Integration Tests September 23, 2025 14:44 — with GitHub Actions Failure
@sdebruyn sdebruyn had a problem deploying to Approve Integration Tests September 23, 2025 14:44 — with GitHub Actions Failure
@sdebruyn sdebruyn had a problem deploying to Approve Integration Tests September 23, 2025 14:44 — with GitHub Actions Failure
@sdebruyn sdebruyn had a problem deploying to Approve Integration Tests September 23, 2025 14:44 — with GitHub Actions Failure
@sdebruyn sdebruyn had a problem deploying to Approve Integration Tests September 23, 2025 14:44 — with GitHub Actions Failure
@sdebruyn sdebruyn had a problem deploying to Approve Integration Tests September 23, 2025 14:44 — with GitHub Actions Failure
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR replaces SQL-style comments (/* ... */) with Jinja-style comments ({# ... #}) across multiple SQL files to resolve compatibility issues with Microsoft-based database adapters that may have problems with SQL comments in Jinja templates.

  • Standardizes comment syntax to use Jinja templating comments throughout the codebase
  • Updates comments in source models, dimension models, macros, and integration test files
  • Maintains the same comment content while changing only the syntax

Reviewed Changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.

File Description
models/sources/*.sql Updated SQL comments to Jinja comments in source model files
models/dim_dbt__current_models.sql Converted multiple inline and block SQL comments to Jinja syntax
macros/upload_results/get_column_name_lists.sql Changed SQL comment to Jinja comment in macro file
integration_test_project/models/microbatch_transaction_base.sql Updated SQL comment to Jinja comment in test model

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@mtcarlone mtcarlone self-assigned this Dec 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants