feat: configurable upload limits #520
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kempspo
had a problem deploying
to
Approve Integration Tests
GitHub Actions
Failure
kempspo
had a problem deploying
to
Approve Integration Tests
GitHub Actions
Failure
kempspo
had a problem deploying
to
Approve Integration Tests
GitHub Actions
Failure
kempspo
had a problem deploying
to
Approve Integration Tests
GitHub Actions
Failure
kempspo
had a problem deploying
to
Approve Integration Tests
GitHub Actions
Failure
kempspo
had a problem deploying
to
Approve Integration Tests
GitHub Actions
Failure
kempspo
had a problem deploying
to
Approve Integration Tests
GitHub Actions
Failure
kempspo
had a problem deploying
to
Approve Integration Tests
GitHub Actions
Failure
kempspo
had a problem deploying
to
Approve Integration Tests
GitHub Actions
Failure
kempspo
had a problem deploying
to
Approve Integration Tests
GitHub Actions
Failure
Author
|
@mtcarlone could i get you to take a look at this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Allow users to configure upload limits and add Trino to lower default limits (similar to BigQuery).
Update type - breaking / non-breaking
What does this solve?
Trino can run into
QUERY_TEXT_TOO_LARGEerrors. Not all users can/want to reconfigure their Trino instances to handle larger text queries.This implementation allows the user to instead configure the batching to lower/higher as needed and adds trino to the smaller default pool.
This implmentation takes the same idea from dbt Lab's dbt_project_evaluator.
Outstanding questions
What databases have you tested with?