Skip to content

Feat/clickhouse support #475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Y-55 wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Feat/clickhouse support #475

Y-55 wants to merge 6 commits into from

Conversation

@Y-55
Copy link

@Y-55 Y-55 commented Jan 18, 2025 •
edited
Loading

Overview

Update type - breaking / non-breaking

  • Minor bug fix
  • Documentation improvements
  • Quality of Life improvements
  • New features (non-breaking change)
  • New features (breaking change)
  • Other (non-breaking change)
  • Other (breaking change)
  • Release preparation

What does this solve?

It adds the needed code to support Clickhouse db.

Outstanding questions

What databases have you tested with?

  • Snowflake
  • Google BigQuery
  • Databricks
  • Spark
  • Clickhouse
  • N/A

@Y-55 Y-55 had a problem deploying to Approve Integration Tests January 18, 2025 20:14 — with GitHub Actions Failure
@Y-55 Y-55 had a problem deploying to Approve Integration Tests January 18, 2025 20:14 — with GitHub Actions Failure
@Y-55 Y-55 had a problem deploying to Approve Integration Tests January 18, 2025 20:14 — with GitHub Actions Failure
@Y-55 Y-55 had a problem deploying to Approve Integration Tests January 18, 2025 20:14 — with GitHub Actions Failure
@Y-55 Y-55 had a problem deploying to Approve Integration Tests January 18, 2025 20:14 — with GitHub Actions Failure
@Y-55 Y-55 had a problem deploying to Approve Integration Tests January 18, 2025 20:14 — with GitHub Actions Failure
@Y-55 Y-55 had a problem deploying to Approve Integration Tests January 18, 2025 20:14 — with GitHub Actions Failure
@Y-55 Y-55 had a problem deploying to Approve Integration Tests January 18, 2025 20:14 — with GitHub Actions Failure
@Y-55 Y-55 had a problem deploying to Approve Integration Tests January 18, 2025 20:14 — with GitHub Actions Failure
@Y-55 Y-55 had a problem deploying to Approve Integration Tests January 18, 2025 20:14 — with GitHub Actions Failure
@Y-55 Y-55 had a problem deploying to Approve Integration Tests January 18, 2025 20:14 — with GitHub Actions Failure
@Y-55 Y-55 had a problem deploying to Approve Integration Tests January 18, 2025 20:14 — with GitHub Actions Failure
@Y-55 Y-55 had a problem deploying to Approve Integration Tests January 18, 2025 20:14 — with GitHub Actions Failure
@Y-55 Y-55 had a problem deploying to Approve Integration Tests January 18, 2025 20:14 — with GitHub Actions Failure
@Y-55 Y-55 had a problem deploying to Approve Integration Tests January 18, 2025 20:14 — with GitHub Actions Failure
@Y-55 Y-55 had a problem deploying to Approve Integration Tests January 18, 2025 20:14 — with GitHub Actions Failure
@Y-55 Y-55 had a problem deploying to Approve Integration Tests January 18, 2025 20:14 — with GitHub Actions Failure
@Y-55 Y-55 had a problem deploying to Approve Integration Tests January 18, 2025 20:14 — with GitHub Actions Failure
@Y-55
Copy link
Author

Y-55 commented Jan 18, 2025

closes #469

@Y-55 Y-55 had a problem deploying to Approve Integration Tests January 18, 2025 20:25 — with GitHub Actions Failure
@Y-55 Y-55 had a problem deploying to Approve Integration Tests January 18, 2025 20:25 — with GitHub Actions Failure
@Y-55 Y-55 had a problem deploying to Approve Integration Tests January 18, 2025 20:25 — with GitHub Actions Failure
@Y-55 Y-55 had a problem deploying to Approve Integration Tests January 18, 2025 20:25 — with GitHub Actions Failure
@Y-55 Y-55 had a problem deploying to Approve Integration Tests January 18, 2025 20:25 — with GitHub Actions Failure
@Y-55 Y-55 had a problem deploying to Approve Integration Tests January 18, 2025 20:25 — with GitHub Actions Failure
@Y-55 Y-55 had a problem deploying to Approve Integration Tests January 18, 2025 20:25 — with GitHub Actions Failure
@Y-55 Y-55 had a problem deploying to Approve Integration Tests January 18, 2025 20:25 — with GitHub Actions Failure
@Y-55 Y-55 had a problem deploying to Approve Integration Tests January 18, 2025 20:25 — with GitHub Actions Failure
@z63
Copy link

z63 commented Nov 19, 2025

Hello @Y-55 , did you give up on this ? I m currently working with dbt & clickhouse, so I will be very pleased to see this PR merged :)

@Y-55
Copy link
Author

Y-55 commented Nov 29, 2025

Hi @z63, the code in this brunch is working fine with Clickhouse, I'm using it on my dbt project, I couldn't dedicate some time to find out why they rejected the merge.

If you have sometime, take a look and follow up with them, I guess it's almost ready but might need a little refactor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Y-55 @z63