Skip to content

PD-2945: Update slide-tags #1567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
Apr 24, 2025
Merged

PD-2945: Update slide-tags #1567

merged 23 commits into from
Apr 24, 2025

Conversation

aawdeh
Copy link
Contributor

@aawdeh aawdeh commented Apr 11, 2025

Checklist

If you can answer "yes" to the following items, please add a checkmark next to the appropriate checklist item(s) and notify our WARP team by tagging @broadinstitute/warp-admins in a comment on this PR.

  • Did you add inputs, outputs, or tasks to a workflow?
  • Did you modify, delete or move: file paths, file names, input names, output names, or task names?
  • If you made a changelog update, did you update the pipeline version number?

Copy link

Remember to squash merge!

Copy link

🔍Version Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
All WDLs and changelog files appear to be valid for this release.

Copy link

🔍Changelog Validation Results:

Comparing changelogs for pipelines that differ from the versions on 'origin/develop':
PairedTag.changelog.md has not been changed and needs to be updated
Optimus.changelog.md has not been changed and needs to be updated
Multiome.changelog.md has not been changed and needs to be updated
Some changelog files need updating. See output for details.
validation_failed

@aawdeh aawdeh changed the title Aa slidetag PD-2945: Update slide-tags Apr 11, 2025
Copy link

Remember to squash merge!

Copy link

🔍Version Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
All WDLs and changelog files appear to be valid for this release.

Copy link

🔍Changelog Validation Results:

Comparing changelogs for pipelines that differ from the versions on 'origin/develop':
PairedTag.changelog.md has not been changed and needs to be updated
Optimus.changelog.md has not been changed and needs to be updated
Multiome.changelog.md has not been changed and needs to be updated
Some changelog files need updating. See output for details.
validation_failed

Copy link

Remember to squash merge!

Copy link

🔍Version Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
All WDLs and changelog files appear to be valid for this release.

Copy link

🔍Changelog Validation Results:

Comparing changelogs for pipelines that differ from the versions on 'origin/develop':
PairedTag.changelog.md has not been changed and needs to be updated
Optimus.changelog.md has not been changed and needs to be updated
Multiome.changelog.md has not been changed and needs to be updated
Some changelog files need updating. See output for details.
validation_failed

Copy link

Remember to squash merge!

Copy link

🔍Changelog Validation Results:

Comparing changelogs for pipelines that differ from the versions on 'origin/develop':
PairedTag.changelog.md has not been changed and needs to be updated
Optimus.changelog.md has not been changed and needs to be updated
Multiome.changelog.md has not been changed and needs to be updated
Some changelog files need updating. See output for details.
validation_failed

Copy link

🔍Version Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
All WDLs and changelog files appear to be valid for this release.

Copy link

Remember to squash merge!

Copy link

🔍Changelog Validation Results:

Comparing changelogs for pipelines that differ from the versions on 'origin/develop':
PairedTag.changelog.md has not been changed and needs to be updated
Optimus.changelog.md has not been changed and needs to be updated
Multiome.changelog.md has not been changed and needs to be updated
Some changelog files need updating. See output for details.
validation_failed

Copy link

🔍Version Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
All WDLs and changelog files appear to be valid for this release.

Copy link

Remember to squash merge!

Copy link

🔍Changelog Validation Results:

Comparing changelogs for pipelines that differ from the versions on 'origin/develop':
PairedTag.changelog.md has not been changed and needs to be updated
Optimus.changelog.md has not been changed and needs to be updated
Multiome.changelog.md has not been changed and needs to be updated
Some changelog files need updating. See output for details.
validation_failed

Copy link

🔍Version Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
PairedTag.wdl has not been changed and needs updating
Optimus.wdl has not had its version updated
Multiome.wdl has not been changed and needs updating
Some WDLs or changelog files need updating. See output for details.
validation_failed

Copy link

Remember to squash merge!

Copy link

🔍Version Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
PairedTag.wdl has not been changed and needs updating
Optimus.wdl has not had its version updated
Multiome.wdl has not been changed and needs updating
Some WDLs or changelog files need updating. See output for details.
validation_failed

Copy link

🔍Changelog Validation Results:

Comparing changelogs for pipelines that differ from the versions on 'origin/develop':
PairedTag.changelog.md has not been changed and needs to be updated
Optimus.changelog.md has not been changed and needs to be updated
Multiome.changelog.md has not been changed and needs to be updated
Some changelog files need updating. See output for details.
validation_failed

Copy link

Remember to squash merge!

Copy link

🔍Version Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
All WDLs and changelog files appear to be valid for this release.

Copy link

🔍Changelog Validation Results:

Comparing changelogs for pipelines that differ from the versions on 'origin/develop':
All changelog files are valid for this release.

Copy link

Remember to squash merge!

Copy link

🔍Changelog Validation Results:

Comparing changelogs for pipelines that differ from the versions on 'origin/develop':
All changelog files are valid for this release.

Copy link

🔍Version Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
All WDLs and changelog files appear to be valid for this release.

Copy link

Remember to squash merge!

Copy link

🔍Version Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
All WDLs and changelog files appear to be valid for this release.

Copy link

🔍Changelog Validation Results:

Comparing changelogs for pipelines that differ from the versions on 'origin/develop':
All changelog files are valid for this release.

Copy link

Remember to squash merge!

Copy link

🔍Changelog Validation Results:

Comparing changelogs for pipelines that differ from the versions on 'origin/develop':
All changelog files are valid for this release.

Copy link

🔍Version Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
All WDLs and changelog files appear to be valid for this release.

Copy link

Remember to squash merge!

Copy link

🔍Version Validation Results:

Comparing versions and changelogs for pipelines that differ from the versions on 'origin/staging':
All WDLs and changelog files appear to be valid for this release.

Copy link

🔍Changelog Validation Results:

Comparing changelogs for pipelines that differ from the versions on 'origin/develop':
All changelog files are valid for this release.

@aawdeh aawdeh merged commit ff3e3e0 into develop Apr 24, 2025
10 checks passed
@aawdeh aawdeh deleted the aa-slidetag branch April 24, 2025 13:20
nikellepetrillo added a commit that referenced this pull request May 27, 2025
* PD-2945: Update slide-tags  (#1567)

* Np add tests peakcalling (#1578)

* add peakcalling test

* add peakcalling test

* add peakcalling test

* turn call caching off

* turn call caching off

* turn call caching off

* turn call caching off

* update input for peakcalling

* add sci test for peakcalling (#1580)

* add sci test for peakcalling

* add sci test for peakcalling

* add sci test for peakcalling

* PD-2937: Update BestPractices.md (#1584)

* PD-2950: Write up SlideTags documentation (#1581)

* Rc 2880 warp and forking (#1586)

* update WARP name

* update WARP name

* Document on Forking WARP and pushing to dockstore

* Updated pipeline_versions.txt with all pipeline version information

---------

Co-authored-by: Farzaneh Khajouei <[email protected]>
Co-authored-by: GitHub Action <[email protected]>

* update to new input paths

* Updated pipeline_versions.txt with all pipeline version information

* Updated pipeline_versions.txt with all pipeline version information

* update to new input paths

* temp copy sci inputs to plumbing for testing purposes only

* PD-2939: Add philosophy section to the get-started page (#1587)

* fix paths

* fix paths

* fix paths

* fix paths

* rearrange input json

* update truth bucket interpretation logic

* dont cancel runs for now

* up memory in CollectAggregationMetrics

* mor emem

* mor emem

* remove jsons

* remove jsons

---------

Co-authored-by: aawdeh <[email protected]>
Co-authored-by: Robert Sidney Cox <[email protected]>
Co-authored-by: Farzaneh Khajouei <[email protected]>
Co-authored-by: GitHub Action <[email protected]>
nikellepetrillo added a commit that referenced this pull request Jun 4, 2025
* PD-2945: Update slide-tags  (#1567)

* Np add tests peakcalling (#1578)

* add peakcalling test

* add peakcalling test

* add peakcalling test

* turn call caching off

* turn call caching off

* turn call caching off

* turn call caching off

* update input for peakcalling

* add sci test for peakcalling (#1580)

* add sci test for peakcalling

* add sci test for peakcalling

* add sci test for peakcalling

* PD-2937: Update BestPractices.md (#1584)

* PD-2950: Write up SlideTags documentation (#1581)

* Rc 2880 warp and forking (#1586)

* update WARP name

* update WARP name

* Document on Forking WARP and pushing to dockstore

* Updated pipeline_versions.txt with all pipeline version information

---------

Co-authored-by: Farzaneh Khajouei <[email protected]>
Co-authored-by: GitHub Action <[email protected]>

* PD-2939: Add philosophy section to the get-started page (#1587)

* updated run_ancestry population metadata tsv and filtering parameters (#1590)

* RNA-seq alignment pipeline for All of Us

* add macaque test input json (#1593)

* add macaque test input json

* Updated pipeline_versions.txt with all pipeline version information

* add macaque test input json

* gzip fastqs

* increase ulimit

* rerun

* rerun

* rerun

* rerun

* changelogs

* Updated pipeline_versions.txt with all pipeline version information

* changelogs

---------

Co-authored-by: GitHub Action <[email protected]>

* point to new exome inputs

* move inputs for now

* Updated pipeline_versions.txt with all pipeline version information

* move inputs for now

* Updated pipeline_versions.txt with all pipeline version information

* Updated pipeline_versions.txt with all pipeline version information

* move inputs for now

* new inputs

* new inputs

* Updated pipeline_versions.txt with all pipeline version information

* Jw ao u filterand qc variants (#1589)

* Add filter and QC WDL and python script

---------

Co-authored-by: GitHub Action <[email protected]>

* dummy commit

* PD-2997: Add tests for Slide-Tags pipeline (#1585)

* test

* test

* Updated pipeline_versions.txt with all pipeline version information

* test

* test

* test

* test

* test

* test

* test

* fix

* test

* Updated pipeline_versions.txt with all pipeline version information

* test

* Updated pipeline_versions.txt with all pipeline version information

* test

* test

* test

* test

* test

* json

* Updated pipeline_versions.txt with all pipeline version information

* json

* add inputs for call to the verifySlideTags wdl

* remove id input to slidetags

* point the inputs to the private bucket for now just so we have access to run tests

* add new task to compare stuff in tarballs

* change name of verifytask alias

* compare csvs using threshold logic

* compare csvs using threshold logic

* indentation

* indentation

* indentation

* indentation

* new threshold

* col specific thresholds

* new csv2 task

* calculate tsse metrics only if fragment data is available

* verbose

* verbose

* no thresholds for csv

* change threshold for eps

* change threshold for eps

* change threshold for eps

* increare more thresholds

* fix compareh5file task

* fix compareh5file task

* exclude some columns from tests.

* exclude some columns from tests.

* exclude some columns from tests.

* exclude some columns from tests.

* exclude some columns from tests.

* rewrite without tolerances

* rewrite without tolerances

* move out of beta

* Updated pipeline_versions.txt with all pipeline version information

* move out of beta

* fix

* fix

* fix imports

* Updated pipeline_versions.txt with all pipeline version information

* add slidetags changelog first release

* Updated pipeline_versions.txt with all pipeline version information

* add slidetags changelog first release

---------

Co-authored-by: GitHub Action <[email protected]>
Co-authored-by: npetrill <[email protected]>
Co-authored-by: Nikelle Petrillo <[email protected]>

* fix input

* update inputs

* fix inputs

* delete

---------

Co-authored-by: aawdeh <[email protected]>
Co-authored-by: Robert Sidney Cox <[email protected]>
Co-authored-by: Farzaneh Khajouei <[email protected]>
Co-authored-by: GitHub Action <[email protected]>
Co-authored-by: Elizabeth Kiernan <[email protected]>
Co-authored-by: Jessica Way <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants