-
Notifications
You must be signed in to change notification settings - Fork 25
Dfp pclr yoda #596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kilonzi
wants to merge
17
commits into
master
Choose a base branch
from
dfp_pclr_yoda
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Dfp pclr yoda #596
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kilonzi
commented
Apr 30, 2025
kilonzi
commented
May 1, 2025
Co-authored-by: John Kitonyo <[email protected]>
Co-authored-by: John Kitonyo <[email protected]>
Co-authored-by: John Kitonyo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a deployment pipeline for the PCLR model, including schema definitions, Docker containerization, and preprocessing/postprocessing scripts. The changes focus on defining input/output formats, creating a Dockerized environment for processing, and implementing scripts for preparing and finalizing data.
Deployment Pipeline Setup:
Model Schema Definition:
Added a JSON schema in
pclr_model_schema.json
to specify the model's input (ecg_tensor
) and output (embed
) formats, including their shapes and data types.Dockerfile for Processing:
Created a
Dockerfile
to set up a lightweight Python 3.9-based environment for running the preprocessing (prepare.py
) and postprocessing (finalize.py
) scripts. It installs dependencies fromrequirements.txt
and sets the entry point to Python.Data Processing Scripts:
Preprocessing Script (
prepare.py
):Added a script to process raw ECG files into HDF5 tensor format. It reads input CSVs, extracts ECG data from files, interpolates and normalizes the data, and saves it in a structured HDF5 format.
Postprocessing Script (
finalize.py
):Added a script to merge model predictions with input metadata. It reads a CSV of metadata and a JSON of predictions, validates dimensions, and outputs a combined CSV with embeddings appended.
Dependencies:
Added a
requirements.txt
file listing the necessary Python libraries (pandas
,numpy
,h5py
,smart-open[gcs]
) for preprocessing and postprocessing.