perf(breadbox): Small breadbox performance tweak #214
Merged
+11
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snwessel
changed the title
jessica-cheng
approved these changes
Mar 10, 2025
breadbox/breadbox/crud/dataset.py
Outdated
| @@ -783,19 +784,21 @@ def get_unique_dimension_ids_from_datasets( | |||
| unique_dims = set() | |||
There was a problem hiding this comment.
Looks like we can remove this with your changes!
breadbox/breadbox/crud/dataset.py
Outdated
|
|
||
| for t_dim in tabular_dimension_ids: | ||
| unique_dims.add(t_dim.dimension_given_id) | ||
| unique_dims = tabular_dimension_ids.union(matrix_dimension_ids) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may no longer be relevant, since it sounds like Randy found a different solution that doesn't use this parameter - but I wanted to commit my changes anyway since they improve performance a bit (and this endpoint may be used again in the future).
Background: Randy noticed that this endpoint takes a long time when
?show_only_dimensions_in_datasets=trueis set (for example, here)Solution: moving a couple of things into the SQLAlchemy query, so that only distinct given IDs are loaded into memory (instead of the full
Dimensionobjects)This makes the endpoint (with the
show_only_dimensions_in_datasetsparameter) about 4x faster with my somewhat-realistic local data.