Remove closePath() #194
Open
Remove closePath() #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closePath "attempts to add a straight line from the current point to the start of the current sub-path" so for a straight line it does nothing, and for a curve it draws back to the start point so if you draw quickly you get an ugly two line effect.
|
Have you done much cross browser testing? especially in older browsers? |
|
It works to specification in IE11 I would assume it appears the same for all browsers listed in the compatibility table here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closePath "attempts to add a straight line from the current point to the start of the current sub-path" so for a straight line it does nothing, and for a curve it draws back to the start point so if you draw quickly you get an ugly two line effect.