Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show sign here label and a line in the background #160

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JianxunSu
Copy link

To make signhere label and a reference line displayed in the background as a svg, this could be alternative to the original Sign Here sticker.

To make signhere label and a reference line displayed in the background as a svg, this could be alternative to the original Sign Here sticker.
Copy link
Owner

@brinley brinley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what is the reason for your change? Why do you need the sign here image in the background? do you need it to persist there? As for the signature line, I get why you would want to put in the background, however the better spot would be to add a flag in jSignature core itself to toggle between background signature line and canvas line (i believe https://github.com/brinley/jSignature/blob/master/src/jSignature.js#L999)

@brinley brinley self-assigned this Dec 26, 2018
@JianxunSu
Copy link
Author

Thanks for your explanation, I didn't notice there is a signature line function exist in core, yes I agree with you that's a better solution. For the sigh here image in the background, this is just a project requirement. I think it needn't to be that in most cases, so this is just an initial work as a reference.

@brinley
Copy link
Owner

brinley commented Feb 3, 2019

Would you like to update the core itself with your feature?

@JianxunSu
Copy link
Author

Sorry to reply late, I m not sure, currently don't have enough time for this, maybe will do it in the future..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants