FinalMessage doesn't scroll into view

brigand · Sep 6, 2017 · 3109ffa · 3109ffa
1 parent 929752f
commit 3109ffa
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/src/atoms/Message.js b/src/atoms/Message.js
@@ -17,6 +17,8 @@ class Message extends React.Component {
 
     // the time it takes to write the message
     length: PropTypes.number.isRequired,
+
+    noScroll: PropTypes.bool,
   };
 
   constructor(props) {
@@ -44,8 +46,12 @@ class Message extends React.Component {
           this.setState({entering: false});
           timeout(EXPAND_DURATION, () => {
             this.setState({didEnter: true});
-            if (this.el.scrollIntoViewIfNeeded) {
-              this.el.scrollIntoViewIfNeeded();
+            if (!this.props.noScroll) {
+              if (this.el.scrollIntoViewIfNeeded) {
+                this.el.scrollIntoViewIfNeeded();
+              } else {
+                this.el.scrollIntoView();
+              }
             }
           });
         });

diff --git a/src/sites/babelrc/BabelSite.js b/src/sites/babelrc/BabelSite.js
@@ -300,7 +300,7 @@ class BabelSite extends React.Component {
     };
 
     return (
-      <Message key={JSON.stringify(this.state)} remote length={LENGTHS.FINAL}>
+      <Message noScroll key={JSON.stringify(this.state)} remote length={LENGTHS.FINAL}>
         <FinalMessage data={data} />
       </Message>
     );