feat: remaining entity service methods #255
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
colesanders
commented
Aug 26, 2024
colesanders
commented
schuchard
reviewed
Aug 26, 2024
| // This seems like a somewhat odd REST API pattern. | ||
| return this.buildUrl('deleteManyByKeys', entityInfo, criteria).pipe( | ||
| switchMap(url => this.http.delete<any>(url, { body: { keys } })), | ||
| map(() => keys) // Will auto entity handle this correctly and remove the entities from state? |
There was a problem hiding this comment.
Since this isn't fully understood, does it need to be added?
There was a problem hiding this comment.
Most of these methods are were asked for by the Timebug team to allow the use of bulk endpoints and reduce the api calls. I figured for now this would work just fine since the generic service would also allow for different bulk delete by key approaches, such as with query params. Also, I did some digging into the deleteManyByKeys and it looks like it should work fine, so I can remove the second comment.
There was a problem hiding this comment.
Sounds good. If you can update or remove the comments we can merge this.
* Fixed issue with operation not being passed to url prefix resolver + Added createMany + Added updateMany + Added replaceMany + Added deleteMany + Added deleteManyByKeys
colesanders
force-pushed
the
feat/remaining-entity-service-methods
branch
from
f835b59 to
2d6d1c6
Compare
strattonwhisler
approved these changes
Sep 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.