[pull] 5.2-dev from joomla:5.2-dev #578
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
…a language string (#44106)
Co-authored-by: Brian Teeman <[email protected]> Co-authored-by: Olivier Buisard <[email protected]>
* fix next exec calculation * cs fix * deprecated comment * not needed any time longer
…44116) * When the tour is a category, the authorization to run should come from the extension associated with those categories. * Improved equality. Co-authored-by: Brian Teeman <[email protected]>
* Check pagination parameters from request * cs * only for CMS router * paramsFromRequest list ---------
* Update .drone.yml grammar/typo * Signing .drone.yml --------- Co-authored-by: Hannes Papenberg <[email protected]>
# Conflicts: # .drone.yml
Thanks to @costafrancesco94 and all others involved - great teamwork 💚
…44755) This reverts commit ca1a8e6. Co-authored-by: Allon Moritz <[email protected]>
* test for reset password required * cs
* [5.2] test user registration workflow * cs * fix
Co-authored-by: Allon Moritz <[email protected]>
… Client Tool (#44656) * [Cypress] Remove Joomla command line dependency With the `SefPlugin.cy.js` test specification, the Joomla command line client tool was added to the Joomla system tests for the first time. This is an additional complexity and dependency. Especially if the test environment is containerised and Cypress container has no PHP installed. And PHP version needs to be 8.1 and additional modules like `php-simplexml` are needed. And with the Docker access rights, `configuration.php` must be opened for writing (`chmod 644`). And then there is the locally running Cypress GUI to be configured... Therefore switched from using the Joomla command line client tool to using the existing `config_setParameter` Cypress command. The original creator of [44253](#44253) could not know as it is not documented (will be solved with another PR and together with enabling `mod_rewrite` and the `AllowOverride All` needed configuration). Since sometimes the first SEF test failed when the entire Joomla System Tests was performed, the following was implemented: * The operations of the `writeRelativeFile` Cypress task are wrapped in a Promise to ensure that they are only resolved when everything is done * The `config_setParameter` Cypress custom command to return a Cypress chainable * Chaining has been implemented everywhere in `SefPlugin.cy.js` For this test spec the Cypress best practice to use `beforeEach` to ensure tests is added to run independently from one another (and needed for other places in the Joomla System Tests – one more PR). As a small side effect the SEF test spec with 9 tests runs faster, e.g. 3 instead of 18 seconds before. Tested with own target Joomla 5.2-dev three times the single test spec on: * Intel macOS 15.2 using Apache/MariaDB * Apple Silicon macOS 15.2 using Apache/MariaDB * Windows 11 24H2 using Laragon/Apache/MySQL ``` npx cypress run --spec tests/System/integration/plugins/system/sef/SefPlugin.cy.js ``` And once the overall test suite: ``` npm run cypress:run ``` * writeRelativeFile() header adapted return Promise Thank @heekc29 for the hint * Delete cy.log in custom command --------- Co-authored-by: Allon Moritz <[email protected]>
Since `setSefDefaults` already returns a Promise (which Cypress understands and waits for), there's no need to wrap it in an anonymous function. Therefore, the code is simplified for more beauty. Thanks to @laoneo for the hint.
Joomla uses html not xhtml so it is not needed to close a `<br` with a `\`
…ess to version 6.4.15 (#44805)
Co-authored-by: Robert Deutz <[email protected]> Co-authored-by: Hannes Papenberg <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )