Skip to content

Conversation

@fongsean
Copy link
Collaborator

@brianpos we released a stable 1.x version last week, just thought it makes sense to bring it into fhirpath-lab.

The most up to date version as of 29/10/2025 is v1.2.8.

Resolved breaking changes on the library API, mainly going from buildForm(Q, QR) -> buildForm({ questionnaire: Q, questionnaireResponse: QR })

I've also added a change in 02b31ee to resolve this issue (private chat.fhir.org DM).

Copilot AI review requested due to automatic review settings October 29, 2025 02:43
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the @aehrc/smart-forms-renderer library from version 1.0.0-alpha.83 to 1.2.8, along with its dependency @aehrc/sdc-populate from 4.6.0 to 4.6.2. The update addresses breaking API changes in the renderer library.

  • Updated buildForm API to accept an object parameter instead of separate parameters
  • Added destructuring of this.raw to convert Vue reactive objects to plain JavaScript objects when passing to the renderer
  • Updated transpilation configuration to include the new renderer version and its dependencies

Reviewed Changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
package.json Updated versions of @aehrc/sdc-populate and @aehrc/smart-forms-renderer to support the new API
package-lock.json Updated lockfile with new package versions and added dependencies (@aehrc/sdc-template-extract, clean-deep, usehooks-ts, etc.)
components/Questionnaire/EditorRendererSection.vue Updated buildForm call to use object parameter syntax instead of positional parameters
pages/Questionnaire/tester.vue Added destructuring of this.raw to plain JS objects before passing to renderer (two locations)
nuxt.config.js Added @aehrc/smart-forms-renderer and uuid to transpile list, reorganized existing dependencies

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants