Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.2.x update for ruby 2.5 #1126

Open
wants to merge 3 commits into
base: 0.2.x
Choose a base branch
from
Open

Conversation

pavelvasev
Copy link

Mysql2 0.2.24 does not compile in ruby 2.5 due to extra check this ruby performs on rb_funcall.
In particular, file result.c had a bug - wrong number (6) of arguments on line 300.

  • This pull request fixes number of arguments to valid value of 7.
  • Also, to publish these change as a gem, a gem version is updated to 0.2.25.

I ask to merge this changeset in master repository and also ask to build and publish gem version 0.2.25.

Fix number of arguments
bump to version 0.2.25
@pavelvasev
Copy link
Author

Anybody alive here?..

@sodabrew
Copy link
Collaborator

sodabrew commented Jul 4, 2020

Can you use a newer version of the gem to that supports current versions of Ruby?

The mysql2 0.2 series is rather out of date.

@pavelvasev
Copy link
Author

Can you use a newer version of the gem to that supports current versions of Ruby?

The mysql2 0.2 series is rather out of date.

Thank you for your reply! I support Rails 2.3 application. We try to switch to Rails 2.3 LTS + Ruby 2.5, and it forces us to use mysql2. And as I understand, 0.2.x is the only branch compatible with ActiveRecord from Rails 2.3..

@sodabrew
Copy link
Collaborator

sodabrew commented Jul 4, 2020

What is Rails 2.3 LTS?

@pavelvasev
Copy link
Author

What is Rails 2.3 LTS?

https://railslts.com/

@pavelvasev
Copy link
Author

Here is their recommendation to use mysql2. https://makandracards.com/railslts/47192-ruby-2-5-support-for-rails-2-3-lts
Actually they motivate it because mysql gem does not compile in ruby 2.5 at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants