-
Notifications
You must be signed in to change notification settings - Fork 548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix build with MariaDB 10.2 headers #1014
base: 0.3.x
Are you sure you want to change the base?
Conversation
Very useful! Thanks! Any updates? :) |
Any updates here? |
@mattherick Could you clarify what kind of updates do you expect here? |
@AlexeyDemidov I only want to know, if the fix will be merged soon, or not. |
@mattherick I'm not a maintainer of this project so I can't tell for sure but this PR is for old 0.3 branch which is unsupported and most TravisCI tests are failing so I wouldn't expect this PR to be merged. |
Apologize for the radio silence on this PR. I do appreciate that you submitted it. Likewise there's a PR that backports some 0.5.x features to the 0.4.x branch. Bottom line is that I have limited bandwidth and I think it's best spent moving the gem forward for latest Ruby, Rails, MySQL and MariaDB versions and features in new releases. I have an unfavorable opinion of upgrading to a latest-and-greatest database version without upgrading the application using that database. If there's an open source application involved, I'd rather help out a random project get to a newer version of Rails than to backport and support old versions of this gem. If there's a corporate application involved, then there's either paid staff to manage a custom backport or budget to contract that work out. Note that you're also not getting Ruby or Rails security or bugfixes either. I don't follow a reason to update versions of this gem that were intended for versions of the Ruby ecosystem that are years out of their community support windows. |
Fixes 0.3 branch to build with MariaDB 10.2 (See #851)