Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix build with MariaDB 10.2 headers #1014

Open
wants to merge 3 commits into
base: 0.3.x
Choose a base branch
from

Conversation

AlexeyDemidov
Copy link

Fixes 0.3 branch to build with MariaDB 10.2 (See #851)

@yiannist
Copy link

yiannist commented Feb 4, 2019

Very useful! Thanks! Any updates? :)

@mattherick
Copy link

Any updates here?

@AlexeyDemidov
Copy link
Author

@mattherick Could you clarify what kind of updates do you expect here?

@mattherick
Copy link

@AlexeyDemidov I only want to know, if the fix will be merged soon, or not.

@AlexeyDemidov
Copy link
Author

@mattherick I'm not a maintainer of this project so I can't tell for sure but this PR is for old 0.3 branch which is unsupported and most TravisCI tests are failing so I wouldn't expect this PR to be merged.

@sodabrew
Copy link
Collaborator

Apologize for the radio silence on this PR. I do appreciate that you submitted it. Likewise there's a PR that backports some 0.5.x features to the 0.4.x branch. Bottom line is that I have limited bandwidth and I think it's best spent moving the gem forward for latest Ruby, Rails, MySQL and MariaDB versions and features in new releases.

I have an unfavorable opinion of upgrading to a latest-and-greatest database version without upgrading the application using that database. If there's an open source application involved, I'd rather help out a random project get to a newer version of Rails than to backport and support old versions of this gem.

If there's a corporate application involved, then there's either paid staff to manage a custom backport or budget to contract that work out. Note that you're also not getting Ruby or Rails security or bugfixes either. I don't follow a reason to update versions of this gem that were intended for versions of the Ruby ecosystem that are years out of their community support windows.

jacksonrayhamilton pushed a commit to cloversites/mysql2 that referenced this pull request Jan 28, 2020
fluffykhv added a commit to fluffykhv/freebsd-ports that referenced this pull request May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants