Skip to content

fix: use pg-protocol CommonJS entrypoint #3749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
zfaustk wants to merge 1 commit into
base: master
Choose a base branch
from
+18 −2
Draft

fix: use pg-protocol CommonJS entrypoint #3749

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/pg/lib/connection.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

const EventEmitter = require('events').EventEmitter

const { parse, serialize } = require('pg-protocol')
const { parse, serialize } = require('pg-protocol/dist/index.js')
const stream = require('./stream')
const { getStream } = stream

Expand Down
2 changes: 1 addition & 1 deletion packages/pg/lib/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ const Result = require('./result')
const utils = require('./utils')
const Pool = require('pg-pool')
const TypeOverrides = require('./type-overrides')
const { DatabaseError } = require('pg-protocol')
const { DatabaseError } = require('pg-protocol/dist/index.js')
const { escapeIdentifier, escapeLiteral } = require('./utils')

const poolFactory = (Client) => {
Expand Down
16 changes: 16 additions & 0 deletions packages/pg/test/unit/protocol-import-tests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
'use strict'

const assert = require('assert')
const fs = require('fs')
const helper = require('./test-helper')
const suite = new helper.Suite()
const test = suite.test.bind(suite)

const connectionSource = fs.readFileSync(require.resolve('../../lib/connection'), 'utf8')
const indexSource = fs.readFileSync(require.resolve('../../lib'), 'utf8')

test('uses the exported pg-protocol CommonJS entrypoint', function () {
require.resolve('pg-protocol/dist/index.js')
assert.match(connectionSource, /require\('pg-protocol\/dist\/index\.js'\)/)
assert.match(indexSource, /require\('pg-protocol\/dist\/index\.js'\)/)
})
Loading