fix: support callback as second argument to CloudflareSocket.write

packages/pg-cloudflare/src/index.ts

@@ -82,11 +82,15 @@ export class CloudflareSocket extends EventEmitter {
     this.emit('data', Buffer.from(value))
   }
 
+  write(data: Uint8Array | string, callback?: (error?: unknown) => void): true | void
+  write(data: Uint8Array | string, encoding?: BufferEncoding, callback?: (error?: unknown) => void): true | void
   write(
     data: Uint8Array | string,
-    encoding: BufferEncoding = 'utf8',
-    callback: (...args: unknown[]) => void = () => {}
-  ) {
+    encodingOrCallback: BufferEncoding | ((error?: unknown) => void) = 'utf8',
+    callback: (error?: unknown) => void = () => {}
+  ): true | void {
+    const encoding = typeof encodingOrCallback === 'function' ? 'utf8' : encodingOrCallback
+    if (typeof encodingOrCallback === 'function') callback = encodingOrCallback
     if (data.length === 0) return callback()
     if (typeof data === 'string') data = Buffer.from(data, encoding)
 

packages/pg-esm-test/pg-cloudflare.test.js

@@ -18,4 +18,23 @@ describe('pg-cloudflare', () => {
 
     assert.doesNotThrow(() => socket.end())
   })
+
+  it('should call the write(data, callback) callback exactly once', async () => {
+    const socket = new CloudflareSocket()
+    socket._cfWriter = { write: () => Promise.resolve() }
+
+    let resolve
+    const promise = new Promise((resolvePromise) => {
+      resolve = resolvePromise
+    })
+    let called = false
+    socket.write(Buffer.from('x'), (error) => {
+      assert.ifError(error)
+      assert(!called)
+      called = true
+      resolve()
+    })
+
+    await promise
+  })
 })