Normalize query config without copying it - #3743
Open
charmander wants to merge 1 commit into
Open
Conversation
charmander
commented
Aug 12, 2026
| class Query extends EventEmitter { | ||
| constructor(config, values, callback) { | ||
| super() | ||
| ;({ |
Collaborator
Author
There was a problem hiding this comment.
(Prettier removes the newline before this for some reason, but I’m not going to dig into that.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thoroughly copying an object with
create(getPrototypeOf(x), getOwnPropertyDescriptors(x))just to read some properties from it is a little awkward and inefficient, and still has potential issues with setters forcallback/values, for example. Follow-up to #3720 using a new backwards-incompatible function that can’t be imported from the outside, deprecating the original (now unused) function because it’s not a very good public API. When/if the callback API is removed, that’ll be a good opportunity to clean things up even more.