Skip to content

perf(utils): fast prepareValue #3370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brianc merged 4 commits into from
Feb 10, 2025
Merged

perf(utils): fast prepareValue #3370

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a8484f5
perf(utils): fast prepareValue
cesco69 Feb 6, 2025
1769b57
fix: lint
cesco69 Feb 6, 2025
7f52b4f
fix: case of undefined
cesco69 Feb 6, 2025
c0e8bfa
fix: review
cesco69 Feb 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 20 additions & 19 deletions packages/pg/lib/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,27 +49,28 @@ var prepareValue = function (val, seen) {
if (val == null) {
return null
}
if (val instanceof Buffer) {
return val
}
if (ArrayBuffer.isView(val)) {
var buf = Buffer.from(val.buffer, val.byteOffset, val.byteLength)
if (buf.length === val.byteLength) {
return buf
if (typeof val === 'object') {
if (val instanceof Buffer) {
return val
}
return buf.slice(val.byteOffset, val.byteOffset + val.byteLength) // Node.js v4 does not support those Buffer.from params
}
if (val instanceof Date) {
if (defaults.parseInputDatesAsUTC) {
return dateToStringUTC(val)
} else {
return dateToString(val)
if (ArrayBuffer.isView(val)) {
var buf = Buffer.from(val.buffer, val.byteOffset, val.byteLength)
if (buf.length === val.byteLength) {
return buf
}
return buf.slice(val.byteOffset, val.byteOffset + val.byteLength) // Node.js v4 does not support those Buffer.from params
}
}
if (Array.isArray(val)) {
return arrayString(val)
}
if (typeof val === 'object') {
if (val instanceof Date) {
if (defaults.parseInputDatesAsUTC) {
return dateToStringUTC(val)
} else {
return dateToString(val)
}
}
if (Array.isArray(val)) {
return arrayString(val)
}

return prepareObject(val, seen)
}
return val.toString()
Expand Down