Improve lint target to check and fix Go version mismatches #36
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve lint target to check and fix Go version mismatches
Summary
Enhanced the
make lint
target to automatically detect and fix Go version mismatches between the installed golangci-lint and the project's Go version requirements. This prevents the error "Go language version used to build golangci-lint is lower than the targeted Go version" that was encountered when golangci-lint was built with an older Go version than specified in go.mod.The updated logic:
GOTOOLCHAIN
to ensure installation with the project's required Go versionReview & Testing Checklist for Human
3 items - needs careful testing due to shell complexity
make lint
detects and fixes the mismatchsort -V
command might behave differently)Recommended Test Plan
GOTOOLCHAIN=go1.23.0 go install github.com/golangci/golangci-lint/cmd/[email protected]
make lint
and verify it detects the mismatch and reinstalls correctlymake lint
again to ensure it doesn't reinstall unnecessarilyNotes
sort -V
for version comparison which should work on most systems but worth testing