-
Notifications
You must be signed in to change notification settings - Fork 18
Changed "page" to "slide", added extensions #16
base: master
Are you sure you want to change the base?
Conversation
Hey, I think this may be nearing to the point where a name change and a split is appropriate, and we're probably going to keep making changes. I don't want to exclude you from updates, but I also don't want to create confusion about what lectric is. Any thoughts? |
We are pre-1.0 on this guy so I don't think we are, or have to for that matter, make any compatibility promises at this time. For that reason alone, I'd love to see if there is a way we can facilitate your changes here. To me, the changes you've listen in this pull don't seem like they stray very far from the initial sketch of what this library could be. What are your thoughts on the code? |
I like the code, it's high on functionality and low on size and bugs. We are going to make further changes to the API, events like start and stop are less clear when there's a autoplay extension, and we're going to make some changes to allow it to resize more easily, and changes to make it work properly with list elements. I would guess that our API and code will be stable in mid to late April. Before then I'd like to play up the extensions and hooks (even just inside MLB) by changing the name of our fork to Frankenslide. I'll leave it a fork, so we'll still be able to push and pull across. |
…s the number of slides per page.
…e frame is visible at a time
…end of carousel and scrollToClass for automatic scrolling to specified class in carousel
…mateDuration for touch sliders, changed toss function
This is a big one.
slider.page()
toslider.currentSlide()
.slidesPerPage
.on
andoff
..subscribe
to.on
slider.getSlideData
to get data attributes off of slidesslider.next/previous/nextPage/previousPage
for easy navigationloop
option which skips to the first frame when you go past the last one.Added extensions: