Fixed to support Whether links should open in a new window/tab #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "open in a new window/tab" admin option was being ignored
|
Although not stated, the option for links to open in a new tab or window is for links in the campaign page displayed by the plugin. The Archive page is different, and has always opened each campaign page in a new tab. |
|
Then how about rephrased the config option and add another one for the archive page? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Whether links should open in a new window/tab admin option was being ignored
I've made a quick fix to use
target=''in case the option is turned off (which is the default). It might be be better to just not declaretarget=in the first place in this case though.