Repository navigation
feat(evals): add cancel_event to Eval and EvalAsync - #881
Merged
Abhijeet Prasad (AbhiPrasad) merged 2 commits intoOct 5, 2026
Merged
Conversation
Accept a threading.Event in both eval entry points and expose it through task hooks. On cancellation, skip queued trials, cancel async work, and wait for running tasks and scorers before raising.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Abhijeet Prasad (AbhiPrasad)
requested review from
Stephen Belanger (Qard) and
Andrew Kent (realark)
October 5, 2026 22:23
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3c3f2be41e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".
Stephen Belanger (Qard)
approved these changes
Oct 5, 2026
Abhijeet Prasad (AbhiPrasad)
deleted the
abhi/python-sdk-pr-equivalent-dbdc0116
branch
October 5, 2026 23:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cancel an evaluation
EvalAsyncandEvalaccept an optionalcancel_event: threading.Event. Keep a reference to the event and callset()when the evaluation should stop. You can also settimeoutin seconds.EvalAsyncTasks do not need to inspect the event to receive async cancellation. Cancelling the
asyncio.TaskrunningEvalAsyncalso stops the evaluation and sets its event.EvalA synchronous task already running in a thread cannot be forcibly stopped. It can check
hooks.cancel_event.is_set()to stop sooner; otherwise the evaluation waits for it to finish. This can make cancellation take longer thantimeout.For a long-running synchronous loop, checking the hook is optional:
flowchart TD A["EvalAsync or Eval"] --> B{"Stop requested?"} B -- "cancel_event.set()" --> C["Stop starting queued trials"] B -- "timeout" --> C C --> D["Running async tasks receive cancellation"] C --> E["Running sync tasks can check hooks.cancel_event"] D --> F["Wait for running work to finish cleanup"] E --> F F --> G["Raise asyncio.CancelledError or asyncio.TimeoutError"]An event that is already set prevents trials from starting. A timeout also sets the supplied event.