Repository navigation
fix(openai): avoid duplicate spans after auto-instrumentation - #880
Merged
Abhijeet Prasad (AbhiPrasad) merged 1 commit intoOct 5, 2026
Merged
Conversation
Recognize the matching class-level setup patcher markers when wrap_openai checks whether a resource is already instrumented. Cover the combined path with a replayed Responses call and assert one span with one set of token metrics. Closes #878
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Abhijeet Prasad (AbhiPrasad)
deleted the
abhi/fix-openai-double-tracing-45f8a215
branch
October 5, 2026 22:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
wrap_openai()'s class-method check against the setup patchers applied byauto_instrument().responses.createcall that asserts one span and one set of token metrics when both entry points are used.Closes #878.
Validation
mise exec -- nox -R -s 'test_openai(latest)' 'test_openai(1.92.0)' 'test_openai(1.77.0)' 'test_openai(1.71.0)' -- --vcr-record=nonemise exec -- nox -s test_openai_ddtrace