Skip to content

test(anthropic): allow variable compaction stop reasons - #870

Merged
Abhijeet Prasad (AbhiPrasad) merged 1 commit into
mainfrom
abhi/fix-anthropic-compaction-93f4cd2a
Oct 5, 2026
Merged

Abhijeet Prasad (AbhiPrasad) merged 1 commit into
mainfrom
abhi/fix-anthropic-compaction-93f4cd2a

Conversation

@AbhiPrasad

@AbhiPrasad Abhijeet Prasad (AbhiPrasad) commented Oct 5, 2026 •

Copy link
Copy Markdown
Member
  • Keep the compaction metadata assertion and remove the brittle stop_reason assertion.
  • Refresh the latest Anthropic cassette with the current max_tokens response.

Fixes #864.

Assert that compaction request metadata is captured without requiring a
specific provider stop reason, and refresh the latest cassette.

Fixes #864
@AbhiPrasad Abhijeet Prasad (AbhiPrasad) changed the title fix(anthropic): allow variable compaction stop reasons test(anthropic): allow variable compaction stop reasons Oct 5, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-05T15:36:41.156194Z 4a01cd7 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@AbhiPrasad
Abhijeet Prasad (AbhiPrasad) merged commit 1d4c419 into main Oct 5, 2026
83 checks passed
@AbhiPrasad
Abhijeet Prasad (AbhiPrasad) deleted the abhi/fix-anthropic-compaction-93f4cd2a branch October 5, 2026 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Anthropic: test_anthropic_beta_messages_create_captures_compaction_metadata can't be re-recorded

1 participant