fix(eve): Don't report fallback model when dynamic model is used#2233
Merged
Conversation
Luca Forstner (lforst)
changed the title
Luca Forstner (lforst)
requested review from
Abhijeet Prasad (AbhiPrasad) and
Stephen Belanger (Qard)
Stephen Belanger (Qard)
approved these changes
Jul 15, 2026
Stephen Belanger (Qard)
left a comment
Stephen Belanger (Qard)
left a comment
Collaborator
There was a problem hiding this comment.
If I'm understanding correctly, this places the model metadata on every child span and explicitly not the root? Does our backend understand this currently for cost computation? If so, LGTM.
Member
Author
yup as per my last knowledge, cost is aggregated through llm spans |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eve has the concept of "dynamic models" and "fallback models". Fallback models are used when the chosen dynamic model doesn't work. Currently eve always reports the fallback model with a
dynamic:prefix when a dynamic model is used. We should not pick this up because it causes completely wrong pricing and model data.