Skip to content

Auth tab initial setup #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 7, 2025
+6 −16
Merged

Auth tab initial setup #119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
154e0cb
remove duplicate intent-filter
saperi22 Sep 25, 2025
40f85f8
- Update androidx.browser to 1.9.0
saperi22 Sep 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,10 @@ buildscript {
"javaTargetCompatibility": sdkTargetJavaVersion,
]


ext.deps = [
'annotation' : 'androidx.annotation:annotation:1.7.0',
'appcompat' : 'androidx.appcompat:appcompat:1.6.0',
'browser' : 'androidx.browser:browser:1.7.0',
'browser' : 'androidx.browser:browser:1.9.0',
'kotlin' : 'org.jetbrains.kotlin:kotlin-stdlib:1.9.20',

// test dependencies
Expand All @@ -29,7 +28,7 @@ buildscript {
]

dependencies {
classpath 'com.android.tools.build:gradle:8.5.2'
classpath 'com.android.tools.build:gradle:8.9.1'
classpath 'org.jetbrains.dokka:dokka-gradle-plugin:1.9.10'
classpath 'org.jetbrains.kotlin:kotlin-gradle-plugin:1.8.0'
}
Expand All @@ -44,9 +43,9 @@ plugins {
version = '3.1.1-SNAPSHOT'
group = "com.braintreepayments"
ext {
compileSdkVersion = 35
compileSdkVersion = 36
minSdkVersion = 23
targetSdkVersion = 35
targetSdkVersion = 36
versionCode = 73
versionName = version
}
Expand Down
9 changes: 0 additions & 9 deletions demo/src/main/AndroidManifest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,15 +47,6 @@
<category android:name="android.intent.category.DEFAULT" />
<category android:name="android.intent.category.BROWSABLE" />

<data android:scheme="https" />
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious why did we need to remove this lines of code?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We had duplicate intent-filter tags.
AuthTab also doesn't require us to have an intent-filter. However, we might still have to keep the intent-filter because of the CCT.

<data android:host="mobile-sdk-demo-site-838cead5d3ab.herokuapp.com" />
</intent-filter>
<intent-filter android:autoVerify="true">
<action android:name="android.intent.action.VIEW" />

<category android:name="android.intent.category.DEFAULT" />
<category android:name="android.intent.category.BROWSABLE" />

<data android:scheme="https" />
<data android:host="mobile-sdk-demo-site-838cead5d3ab.herokuapp.com" />
</intent-filter>
Expand Down
4 changes: 2 additions & 2 deletions gradle/wrapper/gradle-wrapper.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#Mon Jul 17 09:55:05 CDT 2023
#Thu Sep 25 12:23:31 PDT 2025
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-8.7-bin.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-8.11.1-bin.zip
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists