Syncing from upstream OCA/server-auth (16.0) #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssword_write_date value. It happens that when you install the module, all the users that previously existed before that won't have a value set for the new field password_write_date. And when the validation of minimal hours has passed between the last password write date and now is done, it gets an error of unsupported operands between a bool and timedelta. With this change, it won't be necessary to validate the last password date if it's the first time reseting password, and when the password is changed it will correctly save the value on password_write_date and will be working normally afterwards.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 16.0 #496 +/- ##
=======================================
Coverage 42.01% 42.01%
=======================================
Files 8 8
Lines 288 288
Branches 37 37
=======================================
Hits 121 121
Misses 166 166
Partials 1 1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bt_gitbot